-
Notifications
You must be signed in to change notification settings - Fork 15
hal: renesas: rx: Add HAL support for Renesas RX26T #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
hal: renesas: rx: Add HAL support for Renesas RX26T #121
Conversation
c55a752
to
b83b211
Compare
Add HAL support for RX26T using RDP Signed-off-by: Hau Ho <[email protected]> Signed-off-by: Phi Tran <[email protected]>
b83b211
to
bfa3135
Compare
#include "r_bsp_cpu.h" | ||
#include "mcu_clocks.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quytranpzz: It seems that lacked of include for r_bsp_locking.h?
#include "mcu/rx26t/mcu_mapped_interrupts_private.h" | ||
#include "mcu/rx26t/mcu_mapped_interrupts.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quytranpzz : Why we need full path for these includes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect DISCLAIMER.
#endif | ||
|
||
/* Set PLL Multiplier. */ | ||
SYSTEM.PLLCR.BIT.STC = ((uint8_t)((float)BSP_CFG_PLL_MUL * 2.0f)) - 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different from RDPv1.47. Please separate your update for Zephyr into one commit and record it in the readme file.
error = (((float)pclk / ((baud * divisor) * tmp)) - 1) * 100; | ||
abs_error = (error < 0) ? (-error) : error; | ||
|
||
if ((abs_error <= 1.0f) || (SCI_MODE_ASYNC != hdl->mode)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different from RDPv1.47.
Uh oh!
There was an error while loading. Please reload this page.